Add LLVM_GSL_POINTER to llvm::function_ref. #120699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-adt Author: Haojian Wu (hokein) ChangesThis can enable clang to detect dangling assignment issues, see #120698. Full diff: https://github.com/llvm/llvm-project/pull/120699.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/STLFunctionalExtras.h b/llvm/include/llvm/ADT/STLFunctionalExtras.h
index 3b9d40959d7142..f1ebb581996563 100644
--- a/llvm/include/llvm/ADT/STLFunctionalExtras.h
+++ b/llvm/include/llvm/ADT/STLFunctionalExtras.h
@@ -37,7 +37,7 @@ namespace llvm {
template<typename Fn> class function_ref;
template<typename Ret, typename ...Params>
-class function_ref<Ret(Params...)> {
+class LLVM_GSL_POINTER function_ref<Ret(Params...)> {
Ret (*callback)(intptr_t callable, Params ...params) = nullptr;
intptr_t callable;
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
hokein
force-pushed
the
gsl-pointer-function-ref
branch
from
04115c7 to
cf11f15
Compare
chapuni
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can enable clang to detect dangling assignment issues, see #120698.